[php7] lowercase and uppercase same variable declaration

[filt3rek]

Hej,

Haxe lets me declare 2 functions with the same name (one lowercase and second uppercase) but on runtime PHP complains.

[RealyUniqueName]

I think Haxe should not allow that. @ncannasse ?

[nadako]

IMO, we could rename the locals, but for fields yeah, considering reflection and stuff it might be a reasonable target-specific limitation.

[RealyUniqueName]

Why target specific? I think any sane code should not contain such field pairs.

[Gama11]

I'm not sure about that. I could see that happening especially with C# externs and native properties (convention is to capitalize the name) and regular fields.

[RealyUniqueName]

But there is no such convention in Haxe. It could be allowed for externs only.

[ncannasse]

Haxe is case sensitive and we should not annoy all developers on other targets because of one target specific limitation, so I am fine doing a target specific check. I think we had it already actually. Le ven. 26 avr. 2019 18:36, Alexander Kuzmenko <notifications@github.com> a écrit :

…

But there is no such convention in Haxe. It could be allowed that for externs only. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8219 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHZXQC7CQQYBUEZACHMLW3PSMVPZANCNFSM4HIVWBXQ> .

[RealyUniqueName]

Ok. I'll check if I can support such fields on the generator side before disallowing it completely.

[RealyUniqueName]

I think I can support it in all cases except dynamic access, in which case it's most likely the first field in declaration order will be accessed.

[RealyUniqueName]

After some trials I've decided to prohibit such fields pairs for PHP target. It turns out to be a lot of trouble for little gain.
This issue only affects methods. Variables and "var" class fields are case-sesnsitive in PHP runtime.