Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cs] Implement cs.Syntax.code() #10051

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Jan 6, 2021

(and also cs.Syntax.plainCode())

@kLabz kLabz requested a review from nadako January 6, 2021 10:16
std/cs/Syntax.hx Outdated Show resolved Hide resolved
@skial skial mentioned this pull request Jan 6, 2021
1 task
std/cs/Syntax.hx Outdated Show resolved Hide resolved
@kLabz
Copy link
Contributor Author

kLabz commented Jan 21, 2021

Just rebased development but I don't have much hope for CI atm =/

Could this make it to 4.2? (with more work if needed) This would allow me to cleanup things where I currently can't do some things with haxe syntax.

@RealyUniqueName RealyUniqueName added this to the Release 4.2 milestone Jan 21, 2021
@RealyUniqueName
Copy link
Member

I'd merge this for 4.2 once CI settles down.

@kLabz
Copy link
Contributor Author

kLabz commented Jan 28, 2021

@RealyUniqueName sorry to bother you again, but I'm preparing our CI and docker images for 4.2 and I just realized this PR was not merged so our projects don't compile with my images using latest development =/ Could this be merged now that CI is green please?

@Simn Simn merged commit cd359a2 into HaxeFoundation:development Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants