Display stdin #5120
Merged
Display stdin #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Process issues making it hang on linux/travis (the test works for me on windows)
This was referenced Aug 27, 2016
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4651 by adding a new define
-D display-stdinthat will makeparse_hookread the file specified in--displayfrom standard input stream.For the compilation server this introduces a (backward-compatible) protocol feature. To pass the stdin file to a comp server, one should send
\x01after the hxml parameters, then contents of a file, then the final\x00.There are tests included in this PR and we also tested it in my languageserver experiment and it seems to work great.