Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[lexer] leave open-mode on > so we don't parse <div>/>" #8404

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Jun 10, 2019

This reverts commit b17bac7 which breaks inline markup with these kind of self-closing tags:

var a = <something onClick={e -> e.preventDefault()} />;
var b = <something isSelected={42 > 0} />;

@kLabz
Copy link
Contributor Author

kLabz commented Jun 10, 2019

No idea why travis didn't pick this PR..
Anyway, travis build on my fork: https://travis-ci.org/kLabz/haxe/builds/543773078 (will fail for cs on linux because this branch is missing latest fix from RealyUniqueName)

@Simn Simn merged commit 4047071 into HaxeFoundation:development Jun 10, 2019
@skial skial mentioned this pull request Jun 11, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants