Update hl._std.sys.thread.Lock #8744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock bindings
|
Please remove the docstrings from the |
Gama11
reviewed
Sep 2, 2019
std/hl/_std/sys/thread/Lock.hx
Outdated
| class Lock { | ||
| var deque:sys.thread.Deque<Bool>; | ||
| extern class Lock { | ||
| public function new():Void; |
|
This cannot be merged as-it as we need to be able to set the minimal HL version to 1.11, the way we did for Date utc_inf |
|
@ncannasse is it ready to merge? |
|
I think there's still an issue given for documentation generation since we cannot have a std class that is sometimes an abstract on some platforms. please confirm @RealyUniqueName |
|
Yeah, that's bad. Especially given that in the doc we will have it listed as a class, but in an actuall code it will be an abstract. I suggest to change it to something like this: class Lock {
var native:hl.Abstract<"hl_lock">;
<...>
} |
change abstract to class
updae bindings call
|
@RealyUniqueName ok for 4.0 branch |
RealyUniqueName
pushed a commit
that referenced
this pull request
Nov 28, 2019
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haxe implementation of the lock bindings(HaxeFoundation/hashlink/pull/292) suggested by @ncannasse at #8699