-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromatin Preprocessing #43
Comments
Hi, I will try that shortly and get back to you! |
So Im going to try recreating the data or using that data and renaming it. But to verify, the code is specifically looking for something with the naming convention of {self.data_path}/{split}_{self.ref_genome_version}_coords_targets.csv(link to the code below). That doesnt appear to exist or be created in the repo. That being said ill try the repo and try changing that name to the naming convention and using it instead https://github.com/search?q=org%3AHazyResearch+coords_target&type=code |
Hi, |
Hi @lhendre, apologies for the delay. So the coords_target.csv are just the debug_{train|valid|test}.tsv files but with some small modifications (remove sequence, add prefix to target column names, remove duplicates, save as csv) which can be done with this snippet:
|
Hi @cbirchsy, that appears to answer my questions! Im testing it now but this fills in the missing gaps. If this works would it make since for me to open a pr to update the instructions? And potentially adding in a small script for the create_coord_target_files? |
Hi, this appears to work for getting the preprocessing working, do let me know if it would make sense for me to add this in via a PR. We are right now trying to replicate the papers results regarding chromatin and are still running into some issues, so if there are any additional steps let me know, but we are still digging in on our side |
I check your code, isn't output file out/train.tsv instead of train.mat, since your coordinate file read .csv? |
@jimmylihui are you referring to step 4? If you dig into the build file Youll see it then creates the tsv file that is used in the coordinate reading file. I will go back and double check this, but I can also lead a note to ensure there is no confusion if that is helpful |
Hello, I confirm the script @cbirchsy works
However, I tried to reproduce the results on the 7M training for 50 epoch and could only get AUROC 0.8 d_model: 256 P.s. I am training from scratch as commented in github (I could not find a 8 layer model pretained on 1k) Solved my issue, now I can correctly reproduce the results in the chromatin prediction task: At inference one needs to comment from chromatin_profile.yaml --> |
Im working on and using the Chromatin portion of the project; however, I am running into issues with the preprocessing. Can you provide any more details on how you generated the initial data? I have followed Sei and deepsea but I seem to be missing the train_hg38_coords_targets.csv. There been several versions of Sei and deepsea so Im currently going through the old versions but when I follow previous steps I seem to be missing that file?
The text was updated successfully, but these errors were encountered: