Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys error on file reload #452

Closed
ncannasse opened this issue Oct 18, 2018 · 1 comment
Closed

Sys error on file reload #452

ncannasse opened this issue Oct 18, 2018 · 1 comment

Comments

@ncannasse
Copy link
Member

As discussed here:
https://community.heaps.io/t/questions-regarding-live-update/65
Sometimes file change detection will trigger a sys error when trying to read the file.

I'm not sure about the best way to deal with this. We're already trying to open the file with "append" mode just before calling watchCallback in LocalFileSystem.checkFiles. Maybe we should hold the lock during the whole callback handling.

@ncannasse
Copy link
Member Author

@D0pu I think I might have undo some of your changes wrt this with my latest convert patch.

Maybe one way to do it would be (on watch event) to try/catch any error, then if there is an error, retry after 1s - without try/catch this time so we can get the eventual real error. Have to be careful if multiple watch events are triggered in meanwhile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant