-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatially-targeted modesolver #32
Comments
totally agree! maybe already the recently added |
But longterm I really want that, what's missing before I can start implementing it:
Probably it'd be good to have both options? |
Besides that: for PML modes you need to include the PML in the modesolving ;) |
Yes that's why I think instead of subdomains it's even better to keep modes based on the overlap integral with some region of space So in the PML example you mode solve with the PMLs, and get a lot of PML modes that don't overlap with the waveguides (so the overlap integral is small), and they can be automatically rejected |
maybe the cleanest quick way is to use the confinement factor, see end of https://helgegehring.github.io/femwell/photonics/examples/waveguide_modes.html Just calculate it for all returned modes and reject everything below 20% or something |
The more I think about it the more I think it's the cleanest way at all - but still, calculate the |
Yep that's always a good starting point |
This was addressed by #37 right? |
I think originally the idea was to just solve the mode on a subdomain. But as this would lead to errors due to closer boundaries I'd guess we can close this as we have several working ways :) |
I agree that we have several working ways, but having it solve on a subdomain would be very useful. The problem with the current approach is that you might need to solve for a large number of modes to find the mode you are interested in (for example, in some SiN + Si simulations I need to go up to 7 total modes!). This increases significantly the execution time. Maybe an easy workaround for the closer boundaries would be to select only the elements within an ROI and then expand the resulting simulation region with a constant refractive index so that the dimensions are maintained? |
Okay, reopening! Hmm, I'd guess we should keep the surrounding elements the same and just cutoff things which are too far away, right? Another approach could be to once run a simulation with the other waveguide set to "environment" and then use the effective refractive index as a guess? |
It would be great to have a feature to mode solve in a subdomain, or only keep the modes that have X amount of overlap with some spatial region automatically (an example might be enough)
Would be especially useful to deal with PML modes
@HelgeGehring @mdecea
The text was updated successfully, but these errors were encountered: