New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging Dev1.6 for the upcoming hoki v1.6 release #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The complex stellar population subpackage is meant to combine bpass variables with a stelalr formation history to generate more complex populations. To this end, we're implementing a stellar formation history class. The basic SFH class for custom SFH is implemented using scipy splines. This basic class is also tested.
This method allows for the calculation of the event rate at a given lookback time. It uses the BPASS binning for this. This method is much faster, but suffers from a lack of accuracy.
Both functions are implemented for the BPASS spectra. However, the method is similar to the BPASS event rate calculation, which is sub optimal for the spectra calculation. It takes an extremely long time to do the calculation. A for loop of 100000 iterations is present, because each wavelength is seen as it's own "event type". It should be possible to remove this by implementing a function to take the separate wavelengths as a single unit. It would be interesting so see the influence of putting the for loop within a numba function, but thinking about restructuring the function is probably better. Including a "caching" of the BPASS spectra into a pickled DataFrame. Additional test files are required for this to run.
Agewizard errors
yaml update
Runs each individual python version separate
* Installs the requested python version (3.6 and 3.7) and uses `tox-gh-actions` to run the correct tox versions. * self import in `hoki.age.utils` fixed. * Add init files in test folders to account for similarly named test files.
Complex Stellar Populations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding AgeWizard errors, the
age
subpackage, thedata_compiler.py
module to compile models and do model search