Add missing macro values to V3 boards #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heltec: please pull this asap; I can't use my v3 board this way! |
|
Thanks! Will try soonish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without macros defined like
DISPLAY_HEIGHT,DISPLAY_WIDTHandDIO0, features on the V3 boards won't compile properly.This PR corrects the definitions for:
WIFI_LoRa_32_V3,Wireless_Stick_V3, andWIFI_Kit_32_V3This should help fix #156 fix #164 and help with #157 and #161
Thanks!