Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Pandora Protocol #51

Closed
lgordon opened this issue Apr 25, 2012 · 10 comments
Closed

New Pandora Protocol #51

lgordon opened this issue Apr 25, 2012 · 10 comments

Comments

@lgordon
Copy link

lgordon commented Apr 25, 2012

Hermes broken :(

@alexcrichton
Copy link
Contributor

Trying to find a fix, but this time it looks like it's non-trivial. Will update as soon as possible.

@alexcrichton
Copy link
Contributor

pianobar is what I based the API code off of, and I'm watching the corresponding issue there for updates. I'm trying to look into this myself as well.

@tresni
Copy link
Contributor

tresni commented Apr 26, 2012

Temporary fix just posted . Quick look seems to show that synctime retrieved is just current unix timestamp + 350 days.

@tresni
Copy link
Contributor

tresni commented Apr 26, 2012

Here's a possible implementation for Hermes. Be aware that it uses NSURLConnection:sendSynchronousRequest which may cause delays if there is a loss of network connectivity.

@tresni
Copy link
Contributor

tresni commented Apr 26, 2012

Interesting enough, setting syncOffset to -30240000 has the same affect. See ab3d742f56d

@alexcrichton
Copy link
Contributor

I'm gonna see if this works again tomorrow, but for now here's a new build which works with the temporary fix.

Thanks for figuring out the fix! I'll make an official release once this is figured out or it looks like it'll work for at least a few days.

@loupgaroublond
Copy link

This build works for me. Thanks! I'll keep you posted if it breaks again.

@lgordon
Copy link
Author

lgordon commented Apr 26, 2012

new build worked for me too

@tedivm
Copy link

tedivm commented Apr 27, 2012

I know you're getting a lot of this, but it works great here too. Thanks for the quick fix!

@alexcrichton
Copy link
Contributor

v1.0.22 has this fix, and I'll keep a close eye on this to get a better fix in a next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants