Sanitize shortcut names #2449
Merged
Sanitize shortcut names #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyvorld
force-pushed
the
bugfix/sanitize-shortcut
branch
from
2b1f97e
to
a8cddfa
Compare
|
this should only be done on windows, there is no such restriction on linux and mac os (as far as I remember) |
|
seems like we need this sanitation for wineprefixes on linux/macOS rather than for shortcuts, so I guess everyone has a use for it |
flavioislima
approved these changes
Feb 16, 2023
|
Thanks for the contribution @andyvorld |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitize game title for shortcut creation.
Previously games like
Ruined King: A League of Legends Storywill silently fail and create an invalid shortcut namedRuined Kingin windows, due to not filtering reserved characters.Use the following Checklist if you have changed something on the Backend or Frontend: