Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Shortcuts with blank icon #2235

Open
lever1209 opened this issue Dec 19, 2022 · 7 comments
Open

[Windows] Shortcuts with blank icon #2235

lever1209 opened this issue Dec 19, 2022 · 7 comments
Labels
bug:unconfirmed Someone works on identifying the issue Windows

Comments

@lever1209
Copy link

lever1209 commented Dec 19, 2022

Describe the bug

shortcut icons resolve to undefined/undefined for epic games but not gog

Add logs

(10:20:51) INFO:    [Connection]:       Connectivity: check-online
(10:20:51) INFO:    [Connection]:       Pinging external endpoints
(10:20:51) INFO:    [Legendary]:        Running command: "C:\Users\User 1\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary" --version
(10:20:51) INFO:    [Legendary]:        Legendary location: C:\Users\User 1\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary
(10:20:51) INFO:    [Gog]:              GOGDL location: C:\Users\User 1\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl
(10:20:52) WARNING: [Backend]:          Protocol already registered.
(10:20:52) INFO:    [Connection]:       Connectivity: online
(10:20:52) INFO:    [Gog]:              Getting data about the user
(10:20:52) INFO:    [Gog]:              Refreshing access_token
(10:20:52) INFO:    [Gog]:              Token refreshed successfully
(10:20:53) INFO:    [Gog]:              Saved user data to config
(10:20:53) INFO:    [Gog]:              Running command: "C:\Users\User 1\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl" --version
(10:20:55) INFO:    [Backend]:          VCRuntime is installed
(10:20:55) INFO:    [Backend]:          Checking for new Heroic Updates
(10:20:56) INFO:    [Frontend]:         Refreshing Library
(10:20:56) INFO:    [Legendary]:        Refreshing library...
(10:20:56) INFO:    [Legendary]:        Refreshing Epic Games...
(10:20:58) INFO:    [Legendary]:        Game list updated, got 213 games & DLCs
(10:20:58) INFO:    [Gog]:              Getting GOG library
(10:20:58) INFO:    [Backend]:          Frontend Ready
(10:20:58) INFO:    [Legendary]:        installed.json updated, refreshing library
(10:20:58) INFO:    [Legendary]:        Running command: "C:\Users\User 1\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary" list --third-party
(10:20:58) INFO:    [Gog]:              Number of library pages: 1
(10:20:59) INFO:    [Gog]:              Saved games data
(10:21:03) INFO:    [Backend]:          Starting the Download Queue
(10:21:09) INFO:    [Backend]:          

Heroic Version: 2.5.2 Yamato
Legendary Version:  0.20.31 Dark Energy (hotfix #5)
GOGdl Version: 0.5
OS: Microsoft Windows 10 Pro KERNEL: 10.0.19045 ARCH: x64
CPU: Intel Core™ i5-6200U @2.3 
RAM: Total: 15.88 GiB Available: 10.13 GiB
GRAPHICS: GPU0: Intel(R) HD Graphics 520 VRAM: 1024MB

Steps to reproduce

  1. install an epic games game
  2. wait for it to install
  3. look at the desktop
  4. see white rectangles

Expected behavior

icons should be resolved like on linux

Screenshots

image

image

Heroic Version

Latest Stable

System Information

windows 10
heroic 2.5.2

Additional information

No response

@flavioislima
Copy link
Member

I just tested here on windows 11 and it worked just fine.
Have you created these shortcuts on the latest Heroic release? because there was a bug before that.

I tried here for both GOG and Epic games, both worked fine and the shortcut works as intended.

@flavioislima flavioislima added bug:unconfirmed Someone works on identifying the issue Windows labels Dec 22, 2022
@flavioislima flavioislima changed the title Shortcut icons busted [Windows] Shortcuts with blank icon Dec 22, 2022
@matteolomba
Copy link

I have the same issue on Windows 11 22H2(build 22621.963) and Heroic 2.5.2, cleared cache and re-logged into the Epic Account and the issue still persist. I have also tried with the "RESET HEROIC" option but the issue still persists. If I delete the shortcut from the desktop or from the "Remove shortcuts" button and then click on the "Add shortcut" button the icon is present. In the log file there isn't any error. Tell me other things I can do to fix/help to find the issue.

@flavioislima
Copy link
Member

flavioislima commented Dec 22, 2022

@matteolomba exactly just remove and add again, this should fix it.

@andyvorld
Copy link
Contributor

I made a PR (#2449) to fix a semi related issue, in which the backend was trying to create some shortcuts with reserved words/characters within the game name. As this was causing issues with some games on my side. Bloons TD 6 was not one of them, so I am not sure if this ended up being a similar issue.

@mbrozzo
Copy link

mbrozzo commented Jun 2, 2023

I have the exact same problem: the links keep their icon for some time, then after one or more PC restarts the icon is missing. In my case, some icons have been kept, while others have been deleted, seemingly at random.

@PandaWhisperer
Copy link

PandaWhisperer commented Aug 19, 2023

I have the same issue using Heroic 2.9.1 on Windows 11.

The games I tried were Farming Simulator 19 and LEGO® Builder's Journey, in case that matters. Both from Epic Games Store.

EDIT: it seems that going to the game detail page and using "Remove Shortcuts" from the kebap menu, followed by "Add shortcut" fixes this. Not sure why it doesn't work the first time (i.e. on installation).

@OmikroN-TNS
Copy link

OmikroN-TNS commented Aug 20, 2023

I have the same issue using Heroic 2.9.1 on Windows 11.

The games I tried were Farming Simulator 19 and LEGO® Builder's Journey, in case that matters. Both from Epic Games Store.

EDIT: it seems that going to the game detail page and using "Remove Shortcuts" from the kebap menu, followed by "Add shortcut" fixes this. Not sure why it doesn't work the first time (i.e. on installation).

I can confirm that removing shortcuts and create them again works for me too (Windows 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:unconfirmed Someone works on identifying the issue Windows
Projects
None yet
Development

No branches or pull requests

7 participants