Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support common test framework global API #117

Closed
crusoexia opened this issue Jun 5, 2019 · 3 comments
Closed

support common test framework global API #117

crusoexia opened this issue Jun 5, 2019 · 3 comments

Comments

@crusoexia
Copy link
Contributor

Nowadays dev spent half time to read/write/fix UTs, so it would be nice to have the common test apis highlighted.

current yats test file:
Screen Shot 2019-06-05 at 11 02 57 PM

js file highlighted by vim-javascript:
Screen Shot 2019-06-05 at 11 03 18 PM

These keyword are good highlight candidates:

describe it test before after beforeEach afterEach beforeAll afterAll expect assert
@crusoexia
Copy link
Contributor Author

@HerringtonDarkholme Sorry I want to bring this back to table. These keywords are marked as typescriptGlobal, however, they are not part of typescript but apis provide by common test frameworks as jest mocha chai etc., could you give these keywords another identifier other than typescriptGlobal? How about typescriptTestKeywords? With different identifier colorschemes can set different color to the different things.

Thanks

@HerringtonDarkholme
Copy link
Owner

Pull request is welcome.

@crusoexia
Copy link
Contributor Author

Created. Let me know if anything is not match the convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants