Fix like? method for Server Profile

[fgbulsoni]

Scenario/Intent

I'd like to use the .like? method for a ServerProfile with connections declared and it should tell me if my resource is similar or not. This seems related/similar to #89

Environment Details

• OneView SDK Version: 4.1

Steps to Reproduce

Create a server profile with connections specified.
Sample connections:

[
  {
    "id": 1,
    "name": "deploy-network",
    "functionType": "Ethernet",
    "networkUri": "/rest/ethernet-networks/86c5fb2a-563c-4eaa-9927-a73b2f56685f",
    "requestedMbps": 2500,
    "requestedVFs": "Auto",
    "boot": {
      "priority": "Primary",
      "initiatorNameSource": "ProfileInitiatorName"
    }
  },
  {
    "id": 2,
    "name": "corp",
    "functionType": "Ethernet",
    "networkUri": "/rest/ethernet-networks/21cf8ee3-0579-480b-8f77-f595d348d877",
    "requestedMbps": 2500,
    "requestedVFs": "Auto"
  }
]

After the SP is created, assign it to a variable and retrieve it.

Then run

sp_instance.like?(sample_connections)

Expected Result

Since we created the SP with those connections, it should return true to like?

Actual Result

returns false.

[fgbulsoni]

@tmiotto found the issue. Thanks!
in resource.rb, inside the recursive_like? method, in its last elsif:

elsif val != data[key.to_s] && val != data[key.to_sym]

This is not accounting for type differences such as integers and strings.
To fix it:

elsif val.to_s != data[key.to_s].to_s && val.to_s != data[key.to_sym].to_s

[fgbulsoni]

Just for the record, it was identified that ov is returning:
"requestedMbps": "2500"
While when we create the resource, we have:
"requestedMbps": 2500
This type mismatch caused the comparison to evaluate to false.