Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove WPS, use flake8 #443

Closed
AleksandrKosmylev opened this issue Jul 4, 2024 · 7 comments
Closed

remove WPS, use flake8 #443

AleksandrKosmylev opened this issue Jul 4, 2024 · 7 comments
Labels
good first issue Good for newcomers

Comments

@AleksandrKosmylev
Copy link
Contributor

Ожидаемый результат

Отсутствие комментариев # noqa: WPS в проекте.

Текущий экземпляр закомментированной строки

hexlet-friends/contributors/views/mixins.py

Line 7 in 58300b2

from django.db.models import Count, F, Q, Sum, Window # noqa: WPS347

@HelenOne HelenOne added the good first issue Good for newcomers label Jul 8, 2024
@kat-git-hub
Copy link
Contributor

возьму в работу

@fey
Copy link
Collaborator

fey commented Jul 24, 2024

Let's get away from WPS completely. In Hexlet we use flake8

@fey fey changed the title Исправить и удалить закомментированные ошибки линтера (# noqa: WPS) remove WPS, use flake8 Jul 24, 2024
@kat-git-hub
Copy link
Contributor

Removed 'wemake-python-styleguide' from pyproject.toml and changed configuration in setup.cfg

@kat-git-hub
Copy link
Contributor

update poetry.lock

@kat-git-hub
Copy link
Contributor

обновила зависимости - добавила flake8

@fey
Copy link
Collaborator

fey commented Aug 8, 2024

fixed?

@kat-git-hub
Copy link
Contributor

yep, merged and closed

@fey fey closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Hexlet-Friends
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fey @HelenOne @kat-git-hub @AleksandrKosmylev