Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Makefile #36

Closed
roberto-butti opened this issue Oct 19, 2020 · 2 comments
Closed

Improve Makefile #36

roberto-butti opened this issue Oct 19, 2020 · 2 comments
Assignees
@kimcheung
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@roberto-butti
Copy link
Contributor

  • add .PHONY
.PHONY: help phpstan test coverage phpcs allcheck
  • add help section:
help:           ## Show this help.
	@fgrep -h "##" $(MAKEFILE_LIST) | fgrep -v fgrep | sed -e 's/\\$$//' | sed -e 's/##//'

This is a good example:
https://github.com/Hi-Folks/rando-php/blob/master/Makefile
@roberto-butti roberto-butti added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 19, 2020
@kimcheung
Copy link
Contributor

Hi, can I work on this?

@roberto-butti
Copy link
Contributor Author

@kimcheung thank you for your PR. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimcheung kimcheung

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roberto-butti @kimcheung