Return JSON for InternalServerErrors #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfarukabaci
approved these changes
Apr 24, 2020
|
|
||
| INTERNAL_SERVER_ERROR_FALLBACK_MESSAGE = HIPO_DRF_SETTINGS.get( | ||
| "INTERNAL_SERVER_ERROR_FALLBACK_MESSAGE", | ||
| _('Our servers are unreachable at the moment. Please try again a few minutes later.') |
There was a problem hiding this comment.
We need to import gettext_lazy as _ for the translation.
hipo_drf_exceptions/exceptions.py
Outdated
| @@ -1,7 +1,15 @@ | |||
| from django.utils.translation import ugettext_lazy as _ | |||
There was a problem hiding this comment.
ugettext_lazy is deprecated in Django 3.0 so it would be nice if we use gettext_lazy here for the sake of compatibility.
gokselcoban
reviewed
Apr 27, 2020
| json_content_type = "application/json" | ||
| response = get_response(request) | ||
|
|
||
| if str(response.status_code).startswith("5") and request.content_type == json_content_type: |
There was a problem hiding this comment.
This converts all 5XX responses to 500. Should not we check the full status code instead of checking the first character?
|
@efe did you check these docs? Maybe we shouldn't have a middleware at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7