-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return JSON for InternalServerErrors #19
Draft
efe
wants to merge
5
commits into
master
Choose a base branch
from
handle-500
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5d9a762
json_internal_server_error_middleware is implemented.
efe ac601bb
SERVER_ERROR_FALLBACK_MESSAGE is renamed as INTERNAL_SERVER_ERROR_FAL…
efe c85b342
Have alias for django_settings
efe 0c6f182
gettext_lazy is imported.
efe a1a174d
settings renamed as HIPO_DRF_EXCEPTIONS_SETTINGS
efe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,13 @@ | ||
from rest_framework.exceptions import APIException | ||
from rest_framework.status import HTTP_400_BAD_REQUEST | ||
from rest_framework.status import HTTP_400_BAD_REQUEST, HTTP_500_INTERNAL_SERVER_ERROR | ||
|
||
from hipo_drf_exceptions import settings | ||
|
||
|
||
class BaseAPIException(APIException): | ||
status_code = HTTP_400_BAD_REQUEST | ||
|
||
|
||
class InternalServerError(APIException): | ||
status_code = HTTP_500_INTERNAL_SERVER_ERROR | ||
default_detail = settings.INTERNAL_SERVER_ERROR_FALLBACK_MESSAGE |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
from hipo_drf_exceptions import handler | ||
from hipo_drf_exceptions.exceptions import InternalServerError | ||
|
||
|
||
def json_internal_server_error_middleware(get_response): | ||
|
||
def middleware(request): | ||
json_content_type = "application/json" | ||
response = get_response(request) | ||
|
||
if str(response.status_code).startswith("5") and request.content_type == json_content_type: | ||
response = handler(InternalServerError(), {}) | ||
return response | ||
|
||
return middleware |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
from django.conf import settings as django_settings | ||
from django.utils.translation import gettext_lazy as _ | ||
|
||
HIPO_DRF_EXCEPTIONS_SETTINGS = getattr(django_settings, "HIPO_DRF_EXCEPTIONS_SETTINGS", {}) | ||
|
||
INTERNAL_SERVER_ERROR_FALLBACK_MESSAGE = HIPO_DRF_EXCEPTIONS_SETTINGS.get( | ||
"INTERNAL_SERVER_ERROR_FALLBACK_MESSAGE", | ||
_('Our servers are unreachable at the moment. Please try again a few minutes later.') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to import There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you, fixed. |
||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This converts all 5XX responses to 500. Should not we check the full status code instead of checking the first character?