Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement osu!taiko diffcalc #6

Open
Hiviexd opened this issue Sep 28, 2023 · 3 comments
Open

implement osu!taiko diffcalc #6

Hiviexd opened this issue Sep 28, 2023 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed priority:1 important, feels bad without fix

Comments

@Hiviexd
Copy link
Owner

Hiviexd commented Sep 28, 2023

not really sure if this is even possible with a plugin but i remain hopeful

lack of taiko diffcalc is causing the issue where diffs with custom names are always marked as "Easy", which causes an insane amount of false positives, so users have to manually change that to the correct diff, which isn't intuitive nor optimal.

@Hiviexd Hiviexd added bug Something isn't working help wanted Extra attention is needed priority:2 not very important, nice to have at some point labels Sep 28, 2023
@hongaaronc
Copy link
Collaborator

talked briefly with Alchyr and was advised to probably look at the lazer code for the SR calculation:
https://github.com/ppy/osu/blob/master/osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyCalculator.cs

I think it should be possible but not completely sure. will have to look into it a bit more

@hongaaronc
Copy link
Collaborator

hongaaronc commented Sep 29, 2023

Plan is to implement diffcalc the proper way, by putting it in MapsetParser. Naxess is willing to do another release if we do the implementation/submit a PR.

Instructions for setting up and installing MapsetParser with hardcoded "Expert" as default:

  1. Clone https://github.com/Naxesss/MapsetParser or a fork to a local repo
  2. Open <MP directory>/MapsetParser.csproj in Visual Studio
  3. Open <MP directory>/objects/Beatmap.cs, add to line 515: difficulty = Difficulty.Expert;
  4. Go to Build > Build Solution and Build > Build MapsetParser
  5. This will produce a DLL file: <MP directory>/bin/Debug/netcoreapp3.1/MapsetParser.dll
  6. Open Mapset Verifier, go to Settings > Shortcuts > Open Application Folder
  7. Drag the newly built MapsetParser.dll into <MV App Folder>/api/win-x86

As far as diffcalc implementation goes, it looks like the interfaces for MapsetVerifier that Naxess made are super similar to the lazer ones, so migration should be pretty close to 1:1. We should also be sure to keep the lazer license intact.

@hongaaronc hongaaronc added priority:1 important, feels bad without fix and removed priority:2 not very important, nice to have at some point labels Oct 27, 2023
@hongaaronc
Copy link
Collaborator

soon ™️
Naxesss/MapsetParser#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed priority:1 important, feels bad without fix
Projects
None yet
Development

No branches or pull requests

2 participants