Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the patches in cache? #22

Open
ultrazar opened this issue Jun 13, 2021 · 2 comments
Open

Save the patches in cache? #22

ultrazar opened this issue Jun 13, 2021 · 2 comments

Comments

@ultrazar
Copy link
Contributor

I think that the performance of the plugin it's good more or less, talking about the GPU.
The problem comes with the CPU, when you get near the planets surface, the CPU process goes extremaly high, because needs to patch a lot of terrain with only a little movement.

I think it would be a good idea to save every patch in the ram (or disk too) so it will not be necessary to load it every time.

Should I try to implement it?

@Hoimar
Copy link
Owner

Hoimar commented Jun 14, 2021

That sounds like a good idea. The long term plan is to load and save chunks to disk as a different source for height data (apart from procedurally generated).

But perhaps simply caching patches in RAM would be a good idea in the meantime. If you want, you can try to implement it. On the other hand, I'll have to merge your existing changes and clean up the dev and master branches. Optimally, I want to have a stable master and the development branch for the latest features.

@ultrazar
Copy link
Contributor Author

ultrazar commented Jul 2, 2021

Here my try: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants