Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pdb::PageFlags struct #95

Open
Holzhaus opened this issue Oct 13, 2022 · 0 comments · May be fixed by #98
Open

Improve pdb::PageFlags struct #95

Holzhaus opened this issue Oct 13, 2022 · 0 comments · May be fixed by #98

Comments

@Holzhaus
Copy link
Owner

We already have a dependency on the modular_bitfield crate, might make sense to use that instead:

#[bitfield]
pub struct PageFlags {
    unknown1: B1,
    no_data: bool,
    unknown2: B6,
}

Originally posted by @Holzhaus in #93 (comment)
@Holzhaus Holzhaus linked a pull request Nov 5, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(pdb): Use bitflags crate for page flags Holzhaus/rekordcrate
1 participant
@Holzhaus