Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

untap: add missing --force switch #10521

Merged
merged 1 commit into from
Feb 4, 2021
Merged

untap: add missing --force switch #10521

merged 1 commit into from
Feb 4, 2021

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Feb 4, 2021

Functionality added in #9489, but without the flag.
This PR fixes that.

Closes: #10511

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

@BrewTestBot
Copy link
Member

Review period will end on 2021-02-05 at 17:38:17 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 4, 2021
@Rylan12
Copy link
Member

Rylan12 commented Feb 4, 2021

I'd say this can be marked as critical as it's fixing a bug.

@dawidd6 dawidd6 added the critical Critical change which should be shipped as soon as possible. label Feb 4, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 4, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@dawidd6 dawidd6 merged commit 55ae994 into Homebrew:master Feb 4, 2021
@dawidd6 dawidd6 deleted the untap-force-fix branch February 4, 2021 22:11
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 7, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew untap --force returns Error: invalid option: --force
3 participants
@dawidd6 @BrewTestBot @Rylan12