Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pour_bottle?: Check bottle.compatible_cellar? #3250

Merged
merged 1 commit into from
Oct 1, 2017

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Oct 1, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

formula.bottled? is false when the bottle has no sha256,
as with a local bottle. Check bottle.compatible_cellar? instead.

formula.bottled? is false when the bottle has no sha256,
as with a local bottle.
@ilovezfs ilovezfs merged commit d62d496 into Homebrew:master Oct 1, 2017
@sjackman sjackman deleted the pour-bottle branch October 1, 2017 02:28
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants