Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "BottleLoader: Use the formula stored in the bottle" #3249

Closed
wants to merge 1 commit into from

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Oct 1, 2017

Reverts #3176

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Oct 1, 2017

This has broken CI for python3.

==> brew install ./python3-3.6.2.high_sierra.bottle.1.tar.gz
==> FAILED
==> Installing dependencies for python3: pkg-config
==> Installing python3 dependency: pkg-config
==> Downloading https://homebrew.bintray.com/bottles/pkg-config-0.29.2.high_sierra.bottle.tar.gz
Already downloaded: /Users/brew/Library/Caches/Homebrew/pkg-config-0.29.2.high_sierra.bottle.tar.gz
==> Pouring pkg-config-0.29.2.high_sierra.bottle.tar.gz
/usr/local/Cellar/pkg-config/0.29.2: 11 files, 627.3KB
==> Installing python3
Warning: Building python3 from source:
  The bottle needs a /usr/local/Cellar Cellar (yours is /usr/local/Cellar).
==> Downloading https://www.python.org/ftp/python/3.6.2/Python-3.6.2.tar.xz
Already downloaded: /Users/brew/Library/Caches/Homebrew/python3-3.6.2.tar.xz
Error: inreplace failed
setup.py:
  expected replacement of "@@HOMEBREW_PREFIX@@/ssl" with #<Pathname:/usr/local/opt/openssl>
==> brew test python3 --verbose
==> FAILED
Error: Testing requires the latest version of python3

https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/9849/version=high_sierra/console

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Oct 1, 2017

CC @sjackman @MikeMcQuaid

@sjackman
Copy link
Member

sjackman commented Oct 1, 2017

Here's a fix #3250

@ilovezfs ilovezfs closed this Oct 1, 2017
@ilovezfs ilovezfs deleted the revert-3176-bottle-formula branch October 1, 2017 02:27
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants