Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readall: allow readall-ing multiple taps at once #3302

Merged
merged 2 commits into from
Oct 20, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Library/Homebrew/cmd/readall.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#: @hide_from_man_page
#: * `readall` [tap]:
#: Import all formulae in a tap (defaults to core tap).
#: Import all formulae from specified taps (defaults to
#: all installed taps).
#:
#: This can be useful for debugging issues across all formulae
#: when making significant changes to `formula.rb`,
Expand Down Expand Up @@ -31,7 +32,7 @@ def readall
taps = if ARGV.named.empty?
Tap
else
[Tap.fetch(ARGV.named.first)]
ARGV.named.map { |t| Tap.fetch(t) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help at the top needs updated to match the fact it can take multiple taps. Otherwise 👍

end
taps.each do |tap|
Homebrew.failed = true unless Readall.valid_tap?(tap, options)
Expand Down