Custom commands can show help #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We attempted to find the help message for commands before loading custom commands in the path.
|
Also broken (with |
MikeMcQuaid
approved these changes
Nov 19, 2017
|
Nice work again @wendorf, thanks for the fix! |
|
Excellent! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3385 introduced a change to path loading, and loads custom tap paths after trying to render help text. When trying to run something like
brew bundle --help, the path is totally missed and bundle ends up getting called directly.I tried to write an integration test for this in
custom-external-command_spec.rb, but figuring out the interactions between the test, brew path loading, and the test fixture was too tough. I need to not specify a customPATHin order to properly test the path recomposition inbrew.rb, but I was unable to do that and still have my custom command detected. If you have guidance for this, I'll gladly update my PR.