Fix brew bundle --cleanup from stdin
#1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously failing to read a valid `Brewfile` on repeated reads so attempting to cleanup everything. Instead, cache the `Brewfile` DSL in the `install` command and pass it to the `cleanup` command. Fixes #1378
|
Thanks for a quick turnaround @MikeMcQuaid! Bit ashamed that I didn't try to fix it myself, but I'd need an approval from my employer to contribute, and that could take ages :/ |
|
@motohedgehog No worries, you made it much easier through the write-up!
If I can ever help put anything in writing (or even just this) to nudge them in the right direction: shout. It is incredibly selfish of companies to make it easy to use open source internally but hard to contribute fixes back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously failing to read a valid
Brewfileon repeated reads so attempting to cleanup everything.Instead, cache the
BrewfileDSL in theinstallcommand and pass it to thecleanupcommand.While we're here, make some
dslusage elsewhere a little more consistent.Fixes #1378