Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loopback: split into ARK & ACE versions #176100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unitof
Copy link
Contributor

@unitof unitof commented Jun 7, 2024

Similar to audio-hijack and other apps from this developer.

More info: https://weblog.rogueamoeba.com/2024/06/07/now-you-can-install-loopback-in-under-one-minute/#fn1-2024-06-loopback

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@unitof unitof marked this pull request as draft June 7, 2024 21:33
@unitof unitof marked this pull request as ready for review June 7, 2024 21:34
@unitof unitof mentioned this pull request Jun 7, 2024
@unitof
Copy link
Contributor Author

unitof commented Jun 7, 2024

Asked a question in Discussions about a potentially better (possibly worse) way to format this, with the largely similar url and livechecks: https://github.com/orgs/Homebrew/discussions/5431

@unitof
Copy link
Contributor Author

unitof commented Jun 10, 2024

Rewritten with variables as suggested by @SMillerDev https://github.com/orgs/Homebrew/discussions/5431#discussioncomment-9713875

Casks/l/loopback.rb Outdated Show resolved Hide resolved
unitof added a commit to unitof/homebrew-cask that referenced this pull request Jun 10, 2024
unitof added a commit to unitof/homebrew-cask that referenced this pull request Jun 10, 2024
unitof added a commit to unitof/homebrew-cask that referenced this pull request Jun 10, 2024
unitof added a commit to unitof/homebrew-cask that referenced this pull request Jun 10, 2024
@unitof
Copy link
Contributor Author

unitof commented Jun 13, 2024

This is ready to go.

@miccal

This comment was marked as off-topic.

@unitof

This comment was marked as off-topic.

@unitof
Copy link
Contributor Author

unitof commented Jun 15, 2024

Still is ready to go! Unless anything else needed from me?

@unitof
Copy link
Contributor Author

unitof commented Jun 22, 2024

Anything preventing merge I should work on?

@bevanjkay
Copy link
Member

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants