loopback 2.4.1 + split into ARK & ACE versions #176100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Asked a question in Discussions about a potentially better (possibly worse) way to format this, with the largely similar |
|
Rewritten with variables as suggested by @SMillerDev https://github.com/orgs/Homebrew/discussions/5431#discussioncomment-9713875 |
bevanjkay
reviewed
Jun 10, 2024
|
This is ready to go. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Still is ready to go! Unless anything else needed from me? |
|
Anything preventing merge I should work on? |
|
/rebase |
BrewTestBot
force-pushed
the
fix-loopback
branch
from
7bcece8
to
5bcbfb8
Compare
bevanjkay
approved these changes
Jun 22, 2024
unitof
changed the title
Style as suggested by @SMillerDev: https://github.com/orgs/Homebrew/discussions/5431#discussioncomment-9713875 Caveat as suggested by @bevanjkay: Homebrew#176100 (comment) Similar to \`audio-hijack\` and other apps from this developer. More info: https://weblog.rogueamoeba.com/2024/06/07/now-you-can-install-loopback-in-under-one-minute/#fn1-2024-06-loopback
|
@miccal @bevanjkay Sorry to ping, but nudging this back to your attention. Cask is currently two releases behind. |
bevanjkay
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
audio-hijackand other apps from this developer.More info: https://weblog.rogueamoeba.com/2024/06/07/now-you-can-install-loopback-in-under-one-minute/#fn1-2024-06-loopback
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.