Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaak 2024.6.6 (new cask) #177511

Merged
merged 1 commit into from
Jun 27, 2024
Merged

yaak 2024.6.6 (new cask) #177511

merged 1 commit into from
Jun 27, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jun 22, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

yaak
  * Version '2024.6.6' differs from '' retrieved by livecheck.

Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a livecheck

Casks/y/yaak.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member Author

Did not quite anyway to check the latest version, might need some help on it.

@khipp
Copy link
Member

khipp commented Jun 23, 2024

I took a stab at a possible livecheck:

  livecheck do
    url "https://yaak.app/download"
    regex(/href=.*?yaak[._-]v?(\d+(?:\.\d+)+)[._-]#{arch}\.dmg/i)
  end

@chenrui333
Copy link
Member Author

https://yaak.app/download

actually that works for me, thanks! (I was thinking appcast LOL)

@EricFromCanada
Copy link
Member

/rebase

Signed-off-by: Rui Chen <rui@chenrui.dev>

yaak: update app name

Co-authored-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: Bevan Kay <email@bevankay.me>
Co-authored-by: Klaus Hipp <klaus.hipp@stud.tu-darmstadt.de>
@chenrui333 chenrui333 merged commit b6e4cdc into master Jun 27, 2024
11 checks passed
@chenrui333 chenrui333 deleted the yaak branch June 27, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new cask ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants