Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: discovered appcast urls #28873

Closed
colindunn opened this issue Jan 11, 2017 · 26 comments
Closed

Question: discovered appcast urls #28873

colindunn opened this issue Jan 11, 2017 · 26 comments

Comments

@colindunn
Copy link
Contributor

colindunn commented Jan 11, 2017

I have managed to find a number of appcast urls during my trawling of casks but haven't added them yet as they were either:

  • not known for sure that they would work at the time of updating a cask; or
  • known good, but the cask didn't require an update

I'm going to assume that anything that hasn't changed checkpoint in over a week is good and would like to add them.

I don't really want to do them all individually, but I'm concerned that a single failure when updating a lot of casks will make travis ci go mental.

What's the best way to perform the update? Any advice that you can give?

@miccal
Copy link
Member

miccal commented Jan 11, 2017

@colindunn roughly how many are we talking about here?

@colindunn
Copy link
Contributor Author

Maybe 20-30 @miccal. Might be a few more than that. I need to go through a lot manually because I didn't have this use-case in mind when I started storing the data :-)

I could always limit it to small runs?

@miccal
Copy link
Member

miccal commented Jan 11, 2017

@colindunn lets start doing it in small runs, 10 Casks at a time, and then when checked and merged you can add another run of 10.

Sound good?

@colindunn
Copy link
Contributor Author

No problem, I'll do that then @miccal

Leave the issue open and I'll note in each PR as I go?

@miccal
Copy link
Member

miccal commented Jan 11, 2017

Sure, thanks @colindunn.

@colindunn
Copy link
Contributor Author

I may have more than I suspect, first 10 doesn't make it out of A yet. We'll see how it goes with the first lot anyway @miccal

@colindunn
Copy link
Contributor Author

So I'm at 40 now and up to G. I've definitely underestimated how many I've collected.

I doubt I will get any more done today so will continue tomorrow.

@miccal
Copy link
Member

miccal commented Jan 11, 2017

@colindunn Can you please stop here for now, as I am starting to think that some of your appcast url's are not suitable.

Ping @caskroom/maintainers.

Thank you for your efforts so far though.

@miccal miccal added the awaiting maintainer feedback Issue needs response from a maintainer. label Jan 11, 2017
@colindunn
Copy link
Contributor Author

No problem @miccal happy to wait for further feedback

@colindunn
Copy link
Contributor Author

Here are the next 3 as well if it helps with review:

Regarding anything that is a html page/copy of a homepage, the majority of the checkpoints were collected before the new year, so those pages have survived date issue including page copyright updates so should be stable.

@miccal
Copy link
Member

miccal commented Jan 11, 2017

Possibly relevant (and references therein).

@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 11, 2017

Something important about this.

When you add a github releases appcast, then the url should also be changed to get the package they provide in that releases page. That makes it more consistent, since they are updated at exactly the same time, leads to less errors.

The (rare) exception is when a github releases appcast exists but they don’t share compiled packages there.

@vitorgalvao
Copy link
Member

vitorgalvao commented Jan 11, 2017

Don’t worry about those already merged, I’ll take care of them. Warning so we don’t duplicate work. Just keep it in mind for the next PRs.

@miccal
Copy link
Member

miccal commented Jan 11, 2017

Sorry about that @vitorgalvao, I should have looked more carefully before I merged them.

Would you like me to give you a hand?

@vitorgalvao
Copy link
Member

Sorry about that @vitorgalvao, I should have looked more carefully before I merged them.

Not to worry. It’s another of those unwritten rules.

Would you like me to give you a hand?

No need, thank you. Almost done. They’re relatively few and most of them are the exception, actually, so they’re good as they are.

@miccal miccal removed the awaiting maintainer feedback Issue needs response from a maintainer. label Jan 11, 2017
@colindunn
Copy link
Contributor Author

So you guys are happy for me to proceed with what I'm doing here and the appcast urls I'm finding @vitorgalvao @miccal ?

Aside from changing the github links where possible

@vitorgalvao
Copy link
Member

@colindunn Yes, go for it. Appcasts are always welcome. I’d eventually (not near future, since it’s quite a big task) like to setup a system to make the cask files themselves auto-update, and that depends on them having appcasts.

@colindunn
Copy link
Contributor Author

I underestimated how many of these I have very badly it seems, I now have about 110 and still going.

Out of interest, what do people do when an appcast gets updated but there isn't a release becase either:

  • there wasn't an osx release for the particular version
  • it's a pre-release or beta and shouldn't be added until there is an official release

I am noting the new appcast checkpoint but not updating the cask and ignoring it until it changes again, but what is the method used by others or the recommended path?

@vitorgalvao
Copy link
Member

@colindunn In those cases, do not worry, you can just leave it as is.

We had at one point a semi-automated system I built, but scraped it. I’ve learned a lot when it was in use and will make a new one that fixes the previous flaws. In that semi-automated system, the checkpoint: will also be updated in those cases, but otherwise, don’t go out of your way to do it, it isn’t worth it. The appcast is for specific use of those systems.

How are you finding so many, by the way? Are you just going through them all and looking for it?

@colindunn
Copy link
Contributor Author

I have very rough script for going through all the casks in random order and then recording what I find. I manually choose what I think would work (in some cases the html page is obviously static, or I actually find a json call etc) and then I record the checkpoint along with it plus the date added. If it survives a few checks then it looks good.

I've collected a fair bit of data with all this cask trawling. Once I have these appcasts in I will create another issue to show how I'm keeping track of casks where I can't find appcast values to start a discussion around how that might be integrated if it's useful.

I can continue with the tool and/or share it, but I'd prefer to use the collected data to feed back in to the project rather than have a separate tool.

@adidalal
Copy link
Contributor

This is fantastic work - when I added appcasts, they were generally a manual process (record traffic with Charles)

@colindunn
Copy link
Contributor Author

It's still definitely manual @adidalal it's just the recording of the checkpoint and date added that's helping here. I'm up to 130 now, shouldn't be many more than that. Very sorry about the gross underestimation @miccal !

@miccal
Copy link
Member

miccal commented Jan 12, 2017

No problem @colindunn your efforts here a greatly appreciated by myself and I am sure of all the maintainers.

@colindunn
Copy link
Contributor Author

173 total. Just waiting for the last one to pass and the remaining to be merged and I'll close the issue

@miccal
Copy link
Member

miccal commented Jan 12, 2017

Fantastic work @colindunn!

@colindunn
Copy link
Contributor Author

Happy to help :-)

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants