Skip to content

Commit

Permalink
plantuml: depend on openjdk
Browse files Browse the repository at this point in the history
  • Loading branch information
reitermarkus authored and bayandin committed Feb 21, 2020
1 parent fad06da commit f517591
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Formula/plantuml.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ class Plantuml < Formula
homepage "https://plantuml.com/"
url "https://downloads.sourceforge.net/project/plantuml/1.2020.1/plantuml.1.2020.1.jar"
sha256 "ea25f97c72404f9c8bb9fec57d4fc6a8d711de65605ee3ba75c11483942d4509"
revision 1
version_scheme 1

bottle :unneeded

depends_on "graphviz"
depends_on :java
depends_on "openjdk"

def install
jar = "plantuml.jar"
Expand All @@ -18,9 +19,9 @@ def install
if [[ "$*" != *"-gui"* ]]; then
VMARGS="-Djava.awt.headless=true"
fi
GRAPHVIZ_DOT="#{Formula["graphviz"].opt_bin}/dot" exec java $VMARGS -jar #{libexec}/#{jar} "$@"
GRAPHVIZ_DOT="#{Formula["graphviz"].opt_bin}/dot" exec "#{Formula["openjdk"].opt_bin}/java" $VMARGS -jar #{libexec}/#{jar} "$@"
EOS
chmod 0555, bin/"plantuml"
chmod 0755, bin/"plantuml"
end

test do
Expand Down

2 comments on commit f517591

@chuxubank
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why openjdk instead of java?

@SMillerDev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we now have a formula for Java (the openjdk one). This allows us to test tools with updates and generally provide an experience that breaks less often.

Please sign in to comment.