-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httpie 1.0.3 #43471
httpie 1.0.3 #43471
Conversation
@chenrui333, I noticed over on the repo for httpie, that they have a It might be good to update this PR to copy what I did in that PR, since it will ensure all the dependencies are up-to-date, too. |
@jeffbyrnes, sounds good, I will copy your upstream changes. |
Awaiting further updates before merging. |
FYI, upstream changes were accepted by the httpie maintainer. |
Cool, thanks! |
f960e17
to
a4b9d6c
Compare
a4b9d6c
to
f8bfbc8
Compare
Why does it need to patch a file that generates the formula in the formula? It won't affect any usage of httpie right? |
There's a script that can extract the dependencies https://pypi.python.org/pypi/homebrew-pypi-poet which are then inserted into the formula and this is what needs to be done here and all other formulae constructed this way. |
So yeah, the patch won’t work that way, since this is a generated binary we’re installing. So either @javian’s suggestion, or manually copying in the new reps, is what’s needed here. @chenrui333 if you want to close this, I’m happy to take care of it instead! |
@jeffbyrnes we'll take you up on that offer :) |
Created with
brew bump-formula-pr
.