Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpie 1.0.3 #43471

Closed
wants to merge 1 commit into from
Closed

httpie 1.0.3 #43471

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@jeffbyrnes
Copy link
Contributor

@chenrui333, I noticed over on the repo for httpie, that they have a Makefile with a task specifically set up to supply the values for the Homebrew formula, and I opened a PR for their repo, httpie/cli#801, to make the updates over there first.

It might be good to update this PR to copy what I did in that PR, since it will ensure all the dependencies are up-to-date, too.

@chenrui333
Copy link
Member Author

@jeffbyrnes, sounds good, I will copy your upstream changes.

@javian
Copy link
Contributor

javian commented Aug 27, 2019

Awaiting further updates before merging.

@jeffbyrnes
Copy link
Contributor

FYI, upstream changes were accepted by the httpie maintainer.

@chenrui333
Copy link
Member Author

Cool, thanks!

Formula/httpie.rb Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Member

Why does it need to patch a file that generates the formula in the formula? It won't affect any usage of httpie right?

@javian
Copy link
Contributor

javian commented Aug 30, 2019

There's a script that can extract the dependencies https://pypi.python.org/pypi/homebrew-pypi-poet which are then inserted into the formula and this is what needs to be done here and all other formulae constructed this way.

@jeffbyrnes
Copy link
Contributor

So yeah, the patch won’t work that way, since this is a generated binary we’re installing.

So either @javian’s suggestion, or manually copying in the new reps, is what’s needed here.

@chenrui333 if you want to close this, I’m happy to take care of it instead!

@fxcoudert
Copy link
Member

@jeffbyrnes we'll take you up on that offer :)

@fxcoudert fxcoudert closed this Sep 14, 2019
@jeffbyrnes jeffbyrnes mentioned this pull request Sep 14, 2019
5 tasks
@lock lock bot added the outdated PR was locked due to age label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
@chenrui333 chenrui333 deleted the httpie-1.0.3 branch December 18, 2022 04:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants