Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpie: 1.0.3 #44280

Closed
wants to merge 1 commit into from
Closed

httpie: 1.0.3 #44280

wants to merge 1 commit into from

Conversation

jeffbyrnes
Copy link
Contributor

@jeffbyrnes jeffbyrnes commented Sep 14, 2019 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Takes over for #43471

@chenrui333 chenrui333 changed the title Update httpie formula to install httpie v1.0.3 httpie: 1.0.3 Sep 14, 2019
chenrui333
chenrui333 approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

fxcoudert
fxcoudert requested changes Sep 14, 2019
View reviewed changes
Formula/httpie.rb Outdated Show resolved Hide resolved
@fxcoudert
Copy link
Member

Thanks @jeffbyrnes, I am merging now.
Please note our preferred commit message for updates is httpie 1.0.3 (without the :)

@fxcoudert fxcoudert closed this in a55f97b Sep 16, 2019
@jeffbyrnes jeffbyrnes deleted the httpie-1.0.3 branch September 16, 2019 20:20
@lock lock bot added the outdated PR was locked due to age label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev left review comments

@chenrui333 chenrui333 chenrui333 approved these changes

@fxcoudert fxcoudert Awaiting requested review from fxcoudert

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffbyrnes @fxcoudert @SMillerDev @chenrui333