-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtk 9.0.1 #60548
vtk 9.0.1 #60548
Conversation
gdcm build failure reported upstream: https://sourceforge.net/p/gdcm/bugs/509/ |
pcl does not yet support vtk 9. Current progress here: PointCloudLibrary/pcl#4262 |
4b1eef3
to
481196e
Compare
Maybe we can make an vtk@8 formula for those 2 formula and deprecate it right away? |
faff26f
to
25c9356
Compare
In summary:
|
For itk I'd say we drop gdcm support then. |
25c9356
to
8265ffc
Compare
Removed |
8265ffc
to
62dc4b9
Compare
62dc4b9
to
7713df4
Compare
Looks like if you don't tell itk to use the system gdcm, itk will build gdcm and openjpeg from its ThirdParty directory and then will try and install the openjpen pkg-config file, which conflicts with the openjpeg Homebrew formula which is also being installed (see https://github.com/Homebrew/homebrew-core/pull/60548/checks?check_run_id=1086307019#step:5:13006). I've put the itk dependency on vtk@8.2 back in and gdcm back in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dtrodrigues ! Without your contributions it'd be impossible to keep homebrew going. You can feel good knowing that you've made the world a lot better for homebrew users around the world! 👍 🎉
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?Previous work was done here: #58621