Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goocanvas 3.0.0 #69285

Closed
wants to merge 4 commits into from
Closed

goocanvas 3.0.0 #69285

wants to merge 4 commits into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Jan 18, 2021
@chenrui333
Copy link
Member Author

chenrui333 commented Jan 18, 2021 •
edited
Loading

filed a bug report for license, https://gitlab.gnome.org/GNOME/goocanvas/-/issues/12

@chenrui333
Copy link
Member Author

Current license is LGPL-2.0

@chenrui333
Copy link
Member Author

configure: error: Gpredict requires libgoocanvas-2.0-dev looks like we need to create goocanvas@2

@carlocab
Copy link
Member

Is gpredict maintained? If it is I think we want to find out what their timeline for supporting goocanvas 3.0 is.

I'm also currently inclined to just include goocanvas 2.0 as a resource in gpredict, since I'm not sure having just one formula that needs it is enough to justify an additional versioned formula.

@chenrui333
Copy link
Member Author

Is gpredict maintained? If it is I think we want to find out what their timeline for supporting goocanvas 3.0 is.

I'm also currently inclined to just include goocanvas 2.0 as a resource in gpredict, since I'm not sure having just one formula that needs it is enough to justify an additional versioned formula.

yeah, we should use resource rather than versioned formula.

@chenrui333
Copy link
Member Author

I am gonna check if they do have a ticket to support goocanvas 3 or not

@chenrui333 chenrui333 mentioned this pull request Jan 19, 2021
Closed
@chenrui333
Copy link
Member Author

another idea is that we also try patch to see if it can be built against goocanvas 3

@SeekingMeaning SeekingMeaning added the build failure CI fails while building the software label Jan 26, 2021
@chenrui333 chenrui333 mentioned this pull request Jan 31, 2021
Closed
@chenrui333
gpredict: patch to build with goocanvas 3.0.0
84ef481 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333
update patch
9eaac81 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale No recent activity label Feb 22, 2021
@BrewTestBot BrewTestBot closed this Mar 1, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2021
@chenrui333 chenrui333 deleted the bump-goocanvas-3.0.0 branch December 18, 2022 05:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
build failure CI fails while building the software missing license Formula has a missing license which should be added outdated PR was locked due to age stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @carlocab @BrewTestBot @SeekingMeaning