ProjectM 3.1.12 (new formula)

[revmischa]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

[bayandin]

Getting an error on brew test projectm, not sure what the meaning is

Formula requires real test block instead of current stub

[revmischa]

Not really sure what I'm doing wrong in my tests

[SMillerDev]

Not really sure what I'm doing wrong in my tests

The test should be a command a user would issue. And check if the output is as expected. You're currently just checking if files exist (and they don't all exist).

[revmischa]

I don't understand why the exists check fails though

[SMillerDev]

I don't understand why the exists check fails though

It doesn't really matter why, it's not a sufficient test either way so it'll have to be replaced.
We need a test that exercises the some of the functionality of the app.

In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.

• Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
• You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?

Some advice for specific cases:

• If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
• If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
• If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
• Same if the software requires a virtual machine, docker instance, etc. to be running.

[revmischa]

Is this new test satisfactory?

[SMillerDev]

Can you squash all your commits into one with the same title as the PR?

[revmischa]

Squashed

[SMillerDev]

Thanks @revmischa ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

[BrewTestBot]

@SMillerDev has triggered a merge.

[BrewTestBot]

⚠️ @SMillerDev bottle publish failed.

bottle publish failed

[BrewTestBot]

@carlocab has triggered a merge.