qscintilla2: Updated formula for Python3, Added QtDesigner Plugin

[daviewales]

No description provided.

[daviewales]

Hello? Is anyone there?

[MikeMcQuaid]

Can't hardcode the version here. Needs to be a symlink rather than install to this path.

[daviewales]

What's the best way to determine the version of an installed formula?

[MikeMcQuaid]

"#{Formula.factory("qt").opt_prefix}/plugins"

[daviewales]

Never mind. I worked it out.

[daviewales]

So it's better to link to the opt prefix than to the Cellar prefix?

[daviewales]

@dakcarto I think you and I are doing similar things with the include path.

I used ENV.append_path "CPLUS_INCLUDE_PATH", "#{include}", rather than adding it to the args.

[daviewales]

Should I completely remove the plugin code, or just comment it out?

[dakcarto]

@MikeMcQuaid How about moving the ln_sf to post_install, then in the qt formula test for installation of formulae that install a plugin and run their post_install if found? That would re-establish the symlinks.

[MikeMcQuaid]

@daviewales Remove for now.
@dakcarto Nah, we really need to move plugins to a shared location instead.

[dakcarto]

@MikeMcQuaid Yeah that makes more sense. Alternatively, only the third-party plugins could be installed in a shared location, and Qt may be able to be configured to append that directory, similar to the QT_PLUGIN_PATH env var. (Not sure that is possible on Qt's configure setup, though.)

[daviewales]

I wonder if we could use qt.conf to set the plugin directory PATH.

[dakcarto]

I think qt.conf is read only during runtime, per application/process. I don't think it can be read globally by Qt for all processes. (Can't find any data to verify this, though.)

[daviewales]

I have done some quick tests, and I think you might be right.

Perhaps the easiest thing to do would be to install plugins to $(brew --prefix)/var/qt/plugins, or something similar. I'm not sure how you would set up qt to do that yet.

[dakcarto]

By setting -plugindir <dir> on Qt's configure line, I believe.

Since we are (mostly) just referring to the installation of Qt Designer plugins, it is possible to add some code to the qt formula to define the QT_PLUGIN_PATH env var in the Info.plist of the Desinger.app bundle, under the LSEnvironment section. Here is how I have done this for qgis-20, which is recommend by Apple and skips the need for a launcher script. This would allow proper parsing of multiple directories for Designer, but not be very elegant for other plugin types that would be used by Qt developers, e.g. image or SQL plugins.

In those instances, and if those formulae even exist, the caveats could be updated with a notice about using QT_PLUGIN_PATH, much in the same manner as when using PYTHONPATH.

The separate, shared plugins directory sounds best, though, if it can be correctly managed on uninstall of any formulae.

[MikeMcQuaid]

-plugindir sounds good.

[daviewales]

I've removed the plugin code from this pull request now, by the way.

[daviewales]

I've updated this with a Requirement class. Unfortunately it will now fail brew audit, because it uses ARGV.

[daviewales]

If we can merge pygobject3 with ARGV errors in brew audit, can we merge this?