Duti: Yosemite Fix #33011
Duti: Yosemite Fix #33011
Conversation
Closes #33009.
|
|
||
| depends_on "autoconf" => :build | ||
|
|
||
| if MacOS.version == :yosemite | ||
| patch :DATA |
There was a problem hiding this comment.
Link to upstream bug report, please!
There was a problem hiding this comment.
And I'd prefer using the upstream PR .patch instead e.g. https://github.com/moretension/duti/pull/7.patch
There was a problem hiding this comment.
Upstream bug report: moretension/duti#6
There was a problem hiding this comment.
Fixed. I'm pretty sure one of you is going to throttle me one day for consistently forgetting to link to upstream bug reports. I get too excited about fixing things and rush 😺. Pushed a new commit.
There was a problem hiding this comment.
And I'd prefer using the upstream PR .patch instead e.g
@MikeMcQuaid Do we have a policy on which to prefer? I'm never sure which the maintainers prefer we use and why we make those choices.
There was a problem hiding this comment.
Personally I prefer upstream commit > PR commit > gist > inline.
There was a problem hiding this comment.
Thanks! I tend to try and go upstream commit/PR > DomT4/scripts patch > inline.
Generally, if I can't find an upstream commit to use I'll fall back on leaning on my own repository. I don't know why, but using gists tends to unnerve me a touch. I try not to fall into the habit of using my own repository though, in case I'm hit by a bus or something and suddenly a host of patches need replacing.
I live in fear that one day Mike may well actually throttle me for consistently forgetting to link to upstream bug reports for patches.
|
@DomT4 Fear not my throttling ;) |
|
@MikeMcQuaid I do my best not to invoke your wrath too much ;) ;) |
Closes Homebrew#33009. Closes Homebrew#33011. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Closes #33009.