Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled bounds #680

Closed
btecu opened this issue Nov 19, 2020 · 0 comments · Fixed by #687
Closed

Unhandled bounds #680

btecu opened this issue Nov 19, 2020 · 0 comments · Fixed by #687

Comments

@btecu
Copy link
Contributor

btecu commented Nov 19, 2020

While testing filling forms I noticed a few cases where the text had really small font size.
It turned out that the issue was a negative bound, which apparently is valid.
So likely we need Math.abs(bounds.height) here:

if (totalHeight > bounds.height) return fontSize - 1;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant