Mapping validation #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow that's awesome ! Thanks for your work ! Let me do some test (especially about the error outputs) and I will merge it today 👍 |
|
Ok I will perform some fine tuning in the error messages but everything looks good ! Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm starting to work on better error handling, the first step was to validate the mapping before starting the connector.
I used a JSON schema to describe it (which can be used for documentation purpose) and added a set of integrity checks.
I made arbitrary choices regarding those integrity checks, I will be glad to discuss it further with you.