Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management of long forks #35

Open
albertog78 opened this issue Sep 11, 2019 · 1 comment
Open

Management of long forks #35

albertog78 opened this issue Sep 11, 2019 · 1 comment
Assignees

Comments

@albertog78
Copy link
Contributor

In current implementation, if node A is synced up to a certain block and node B, being on a fork started NetworkSettings.desiredInvObjects + 1 blocks before A tip, node B even if "understand" the exact branching point of node A, will send just NetworkSettings.desiredInvObjects ids of its active chain. In such situation A, even after having received these new blocks, will publish the new SyncInfo without any information about these new blocks (node A is still on the old branch) and for this reason B will again send to A the same NetworkSettings.desiredInvObjects blocks already sent at the previous iteration. This will be a never ending loop preventing the two nodes to converge to the same tip.
Using the locator (and not just the simple contiguous list of ids) will even cause the problem more easily.

@i-Alex
Copy link
Contributor

i-Alex commented Oct 16, 2019

Also review MainchainSynchronizer class

@i-Alex i-Alex removed their assignment May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants