[Small] Disable summary for non-master processes in DDP training mode #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emailweixu
requested changes
Jul 30, 2021
| @@ -138,7 +138,10 @@ def __init__(self, config: TrainerConfig, ddp_rank: int = -1): | |||
| def train(self): | |||
| """Perform training.""" | |||
| self._restore_checkpoint() | |||
| alf.summary.enable_summary() | |||
| if self._rank <= 0: | |||
There was a problem hiding this comment.
In Algorithm._train_experience(), enable_summary() is also called, so this will not be effective.
There was a problem hiding this comment.
You may consider to change run_under_record_context so that _cond() always returns False.
|
Based on the feedback, I will replace this PR with a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to only having process 0 (master process) writing checkpoint, we want to have only process 0 writing the summary. This is done by not enabling summary unless the process rank is 0 (or -1) when setting up
PolicyTrainer.Testing
Tested training in dual GPU settings with this PR. There are still 2 events file generated but only one is being written to.