Delete cookie on logout #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this pull request still open? |
|
👍 This would be a really nice feature. When I am using a public computer and I hit the log out button, I would expect that I'd have to re-enter all my login information, including 2-FA. |
|
Thanks |
|
Hi @Houdini! I was wondering when will be released code from Thanks! |
|
Could you please release a new gem version to include this feature? |
|
@shifi you can get the gem from GitHub on master branch |
|
@shifi I'll do it right now |
|
@shifi please check version 2.1.0 |
|
Thank you @Houdini 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the cookie when the user logs out to force 2fA again on login.