Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in warden hook #89

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Fix crash in warden hook #89

merged 1 commit into from
Jul 1, 2016

Conversation

sbc100
Copy link
Contributor

@sbc100 sbc100 commented Jun 30, 2016

It seems that in some cases action_dispatch.cookies is not
set in the environment during the after_authentication
hook.

@sbc100
Fix crash in warden hook
1a27f42 
It seems that in some cases `action_dispatch.cookies` is not
set in the environment during the `after_authentication`
hook.
@Houdini Houdini merged commit 55f27d5 into Houdini:master Jul 1, 2016
@Houdini
Copy link
Owner

Houdini commented Jul 1, 2016

Thanks

@sbc100 sbc100 deleted the fix_nil_exception branch July 21, 2016 18:13
@maschwenk
Copy link

maschwenk commented Apr 24, 2017 •
edited
Loading

It would be cool to get this backported to 1.1.5 as well?. I'd happily do it myself but I don't have access. Similar situation to #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @Houdini @maschwenk