Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle ^7.0 #326

Closed
robtesch opened this issue Sep 3, 2020 · 11 comments
Closed

Guzzle ^7.0 #326

robtesch opened this issue Sep 3, 2020 · 11 comments

Comments

@robtesch
Copy link

robtesch commented Sep 3, 2020

Hi guys,

Thanks for the lib. Are there any plans to bump the guzzle dependency to ^7.0 any time soon?

Kind regards,

Rob

@atanasiuk-hubspot
Copy link
Collaborator

Hi, @robtesch

Are there any plans to bump the guzzle dependency to ^7.0 any time soon?

We don't have any plans for this. All our efforts are in https://github.com/HubSpot/hubspot-api-php/
Consider upgrading to a new https://developers.hubspot.com/docs/api/overview API

@robtesch
Copy link
Author

robtesch commented Sep 4, 2020

Hi @atanasiuk-hubspot thanks for the update. What is the readiness of https://github.com/HubSpot/hubspot-api-php/? Can I switch to that for production purposes already?

I noticed that even there you are using guzzle ^6.2.

The reason I am asking about this, is that I have some other dependencies that are now guzzle 7+, so i cannot update them until this or the new hubspot-api-php also support it, however I completely understand if it's not a priority at the moment.

Kind regards,

Rob

@streamingsystems
Copy link

Hi All,

I wanted to also inquire about Guzzle 7.

Laravel 8 released today and they have a v7 requirement for Guzzle so us Laravel & Hubspot users (which I would surmise are many) can't upgrade to 8.

Thanks for all of your work on this API.

-Rob

@voicecode-bv
Copy link

Hi guys,

Can you please allow us to use Guzzle 7. As @streamingsystems said, we need this as we can't upgrade to Laravel 8.

Thanks a lot!

Michael

@streamingsystems
Copy link

I was able to work around this until the actual changes are made to the repo by following this article:

https://blog.42mate.com/overriding-composer-dependencies/

If you want to use my repo:

  1. Add this to your Laravel composer.json in the repositories section:

{
"type": "git",
"url": "https://github.com/streamingsystems/hubspot-php.git"
},

  1. Replace the HubSpot "require" with this:

"hubspot/hubspot-php": "master"

  1. Upgrade to Laravel 8 as usual. You might hit others that use an old Guzzle and stop the upgrade. I had to do the process in the article about to about 5 repos, but finally I was on Laravel 8.

Let me know if I can help.

-Rob

@voicecode-bv
Copy link

@streamingsystems thanks for the fix. I've tried it but it doesn't work because I use rossjcooper's wrapper (rossjcooper/laravel-hubspot).

@streamingsystems
Copy link

streamingsystems commented Sep 18, 2020

I think you can accomplish this by forking his repo. Then in the fork adding my repo for GitHub instead of the default one.

Then in your composer reference your repo.

I am new to this advanced stuff in GitHub/Composer but was able to get it working.

It's worth a try as I don't know how much this HubSpot repo is going to be updated.

I can give you a hand.. but I don't know a way (via private PM) to connect.. if you give me a way to reach out to you I can assist.

@rossjcooper
Copy link

Hi, it would be great if one of the packages would support Guzzle 7, would you accept a PR to cover this?

@rossjcooper
Copy link

Ahh looks like @drjdr has beat us too it #327 👏

@drjdr
Copy link
Contributor

drjdr commented Oct 12, 2020

#333 solves this, new version bump to go

@ksvirkou-hubspot
Copy link
Collaborator

Hi everyone
Check new version please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants