Fix darkened camera view #5577
Merged
Fix darkened camera view #5577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
approved these changes
Jul 14, 2022
src/components/camera-tool.js
Outdated
| @@ -128,8 +128,7 @@ AFRAME.registerComponent("camera-tool", { | |||
| material.toneMapped = false; | |||
|
|
|||
| // Bit of a hack here to only update the renderTarget when the screens are in view | |||
There was a problem hiding this comment.
We can remove this comment now
There was a problem hiding this comment.
Not sure if it is a hack anymore but I think only update the renderTarget when the screens are in view comment is still helpful. What do you think?
| this.screen.matrixNeedsUpdate = true; | ||
| this.el.setObject3D("screen", this.screen); | ||
|
|
||
| this.selfieScreen = new THREE.Mesh(geometry, material); | ||
| this.selfieScreen.position.set(0, 0.4, 0); | ||
| this.selfieScreen.scale.set(-2, 2, 2); | ||
| this.selfieScreen.onBeforeRender = onBeforeRender; |
There was a problem hiding this comment.
Hmm don't remember why we didn't do this originally... I bet we were doing the actual rendering work in the update callback before and we didn't want to do it twice so we applied it to the material instead of the object. This definitely makes more sense now though given its only setting a flag anyway.
The recent Three.js relies on WebGL for sRGB - Linear color space conversion. But it does in shader for video textures for a performance reason. camera-tool sets isVideoTexture = true for the screen render target texture to update the render target only when the screens are in view as hack. But this hack causes a wrong color space conversion and the camera views are darkened. This commit resolves the problem by removing the hack and rewriting it more properly.
takahirox
force-pushed
the
FixDarkenCamera
branch
from
69b815c
to
b0ad205
Compare
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5571
The recent
Three.jsrelies onWebGLfor sRGB - Linear color space conversion. But it still does it in shader for video textures for a performance reason.camera-toolsetsisVideoTexture = truefor the screen render target texture to update the render target only when the screens are in view as hack. But this hack causes a wrong color space conversion and the camera views are darkened.This PR resolves the problem by removing the hack and rewriting it more properly.