Fix darkened video-texture-target #5615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes darkened video-texture-target problem caused when upgrading our Three.js to r141. Refer to "Fix darkened camera view" commit for the details because the root issue is same. The previous same purpose commit was reverted because it didn't work correctly because of losing material.onBeforeRender when cloning materials. This commit resolves it by copying the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5599
This PR fixes darkened video-texture-target problem caused when upgrading our Three.js to r141.
Refer to "Fix darkened camera view" PR #5577 for the details because the root issue is same.
The previous same purpose PR #5604 was reverted because it didn't work correctly because of losing
material.onBeforeRenderwhen cloning materials. This PR resolves it by copying the function.