Fix 52: tests only include sentences with no unknown terms. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the pull request! As explained in #52 , it would really limit the number of testable sentences. So instead of using sentence were you understand all words, I selected "meaningful" sentences with 70% of known words. Enjoy! |
jzohrab
deleted the
fix_tests_only_use_sentences_with_no_unknown_terms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #52 .
I believe that the subquery is correct -- it works with my local test data. @HugoFara , can you verify? (The
Ti2WordCountis checked for non-zero because it appears that it is zero for things like spaces, punctuation, etc).