-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign correct time zone #66
Comments
What should the default be? I haven't thought about this in a while, but the system time seems kinda reasonable for most agency work. |
No, because it actually comes in as UTC, but the computer tries to assign it as system time, which would make all analyses off by a lot (7 hours for mountain) I have verified with Telonics that the data are recorded as UTC. I have verified with Vectronic that the acquisitiontime column from the API is UTC. |
Depends on which column we pick then, no? What is your proposal for a default? Could be an error. What about DST? How strictly are they defining UTC? |
Since we know how Vectronic is coming in, we could hard-code it. We could also verify how Lotek and ATS come in. Otherwise, I like the idea of an error. It will make people annoyed, but whenever you're introducing POSIX, I feel strongly that it should be purposefully assigned a time zone. |
I don't want to favor any one company. I also remember data structures with multiple time columns, so skeptical of any default being correct. I think I like the error as well. |
Can you point me to the function you are commenting on here? Are you going to propose a solution or are you asking someone else to do it? Thanks |
collar::morph_gps I wanted to make a note so we don't forget. I might be able to propose a solution at a later date. |
Re: confirming time data expectations with manufacturers, this is from ATS in 2017:
And this is from the same guy at ATS in 2019, after someone I worked with realized the times didn't make sense:
It's a different company, I know, but my point is just that some of the people providing the data don't even know what's going on. I was using a really similar workflow to the ATS web scraper in this package. Always a moving target... |
Feature request - assign the correct time zone when manipulating collar data. If left blank (as current), it tries to assign system time, which is incorrect.
The text was updated successfully, but these errors were encountered: